Skip to content

Commit

Permalink
Merge pull request #450 from bertrandom/master
Browse files Browse the repository at this point in the history
Fixes a bug where args were being overridden by previous requests when using requestOptionsTransport
  • Loading branch information
aoberoi authored Jan 12, 2018
2 parents 081d79c + 9910f64 commit c3c015a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/clients/transports/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ var HttpsProxyAgent = require('https-proxy-agent');
var has = require('lodash').has;
var partial = require('lodash').partial;
var defaults = require('lodash').defaults;
var cloneDeep = require('lodash').cloneDeep;
var request = require('request');

var handleRequestTranportRes = function handleRequestTranportRes(cb, err, response, body) {
Expand Down Expand Up @@ -64,7 +65,8 @@ var proxiedRequestTransport = function proxiedRequestTransport(proxyURL) {

var requestOptionsTransport = function requestOptionsTransport(options) {
return function _requestOptionsTransport(args, cb) {
var requestArgs = defaults(options, getRequestTransportArgs(args));
var instanceOptions = cloneDeep(options);
var requestArgs = defaults(instanceOptions, getRequestTransportArgs(args));
request.post(requestArgs, partial(handleRequestTranportRes, cb));
};
};
Expand Down

0 comments on commit c3c015a

Please sign in to comment.