Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the default OAuth page renderer #1604

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Improve the default OAuth page renderer #1604

merged 1 commit into from
Apr 13, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 13, 2023

Summary

This pull request improves the default OAuth page rendering code not to embed unescaped parameters in web page content. See also: slackapi/python-slack-sdk#1352

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper` labels Apr 13, 2023
@seratch seratch self-assigned this Apr 13, 2023
@seratch seratch added this to the [email protected] milestone Apr 13, 2023
@seratch seratch merged commit 2af11fa into slackapi:main Apr 13, 2023
@seratch seratch deleted the oauth-default-renerer branch April 13, 2023 05:48
@seratch seratch mentioned this pull request Apr 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seratch seratch

Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper`
Projects
None yet
Milestone
[email protected]
Development

Successfully merging this pull request may close these issues.
1 participant
@seratch