Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Adding deprecation notices to Dialogs and Steps From Apps types #1655

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 30, 2023

Also added information about Message Attachments: while not deprecated per se, there be dragons.

This is in preparation for larger changes I am planning in this package that will warrant a major version upgrade. Might as well deprecate the types we no longer officially support so that we can remove them in a future major version.

@filmaj filmaj added area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` labels Aug 30, 2023
@filmaj filmaj added this to the [email protected] milestone Aug 30, 2023
@filmaj filmaj requested a review from a team August 30, 2023 21:13
@filmaj filmaj self-assigned this Aug 30, 2023
…s. Also added information about Message Attachments: while not deprecated per se, there be dragons.
@filmaj filmaj force-pushed the type-deprecations branch from 4fe7bf6 to 29d5039 Compare August 30, 2023 21:16
Copy link
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filmaj filmaj merged commit da5da33 into main Aug 31, 2023
@filmaj filmaj deleted the type-deprecations branch August 31, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants