socket-mode: add more debug logging to low level websocket event handlers #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lers, differentiate between primary and secondary websocket events in logs.
filmaj
added
semver:patch
enhancement
zimeg
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also differentiate between primary and secondary websocket events in logs.
I have a suspicion that sometimes, both primary and secondary websockets could be briefly active and overlapping, however both websockets emit events into the SINGLE state machine configuration - I wonder if that could lead to unexpected state transitions (two websockets each with their own independent events being emitted into a single state machine).
NOTE: this change probably should cherry-picked into a new
socket-mode-1.3.xmaintenance branch, and a 1.3.4 patch release could be cut from that.