Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-test(trace): include test trace constants for 'datastore count' #1795

Merged
merged 1 commit into from
May 27, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented May 25, 2024

Summary

This PR adds test trace constants for the datastore count command. Should be available in CLI release >2.25.0 - current release is 2.24.0, one release that and this - so unsure when the best time to merge is 🤔 Opening the PR now to have this ready whenever though!

Requirements

@zimeg zimeg added semver:minor enhancement M-T: A feature request for new functionality pkg:cli-test applies to `@slack/cli-test` labels May 25, 2024
@zimeg zimeg added this to the [email protected] milestone May 25, 2024
@zimeg zimeg self-assigned this May 25, 2024
Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (5efe7f3) to head (212331c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1795   +/-   ##
=======================================
  Coverage   80.41%   80.41%           
=======================================
  Files          35       35           
  Lines        7586     7589    +3     
  Branches      308      308           
=======================================
+ Hits         6100     6103    +3     
  Misses       1474     1474           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.07% <ø> (ø)
cli-test 45.59% <100.00%> (+0.11%) ⬆️
oauth 76.51% <ø> (ø)
socket-mode 59.41% <ø> (ø)
web-api 96.48% <ø> (ø)
webhook 95.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj filmaj merged commit c3725a9 into main May 27, 2024
21 checks passed
@filmaj filmaj deleted the cli-test-trace-datastore-count branch May 27, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:cli-test applies to `@slack/cli-test` semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants