feat (web-api): add support for teams.externalTeams.disconnect API
#1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
added
semver:minor
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1837 +/- ##
==========================================
+ Coverage 81.83% 81.85% +0.01%
==========================================
Files 35 35
Lines 7774 7781 +7
Branches 318 318
==========================================
+ Hits 6362 6369 +7
Misses 1400 1400
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
filmaj
commented
Jul 3, 2024
| /** | ||
| * @description Returns a list of all the external teams connected and details about the connection. | ||
| * @see {@link https://api.slack.com/methods/team.externalTeams.list `team.externalTeams.list` API reference}. | ||
| */ | ||
| lookup: bindApiCall<TeamExternalTeamsListArguments, TeamExternalTeamsListResponse>(this, 'team.externalTeams.list'), | ||
| list: bindApiCall<TeamExternalTeamsListArguments, TeamExternalTeamsListResponse>(this, 'team.externalTeams.list'), |
There was a problem hiding this comment.
I made a booboo here previously 😞 😢
filmaj
commented
Jul 3, 2024
| @@ -37,10 +38,6 @@ interface Message extends Channel { | |||
| /** @description Unique identifier of message. */ | |||
| ts: string; | |||
| } | |||
| interface TargetTeam { | |||
There was a problem hiding this comment.
Factored this out into common.js as it's also used for various team.* APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.