Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-api(fix): revert use of export type * to maintain backwards compatibility with TS 4.7 #1841

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jul 4, 2024

Also add an "integration test" to ensure integrating web-api in a project with TS 4.7.2 works.

This fixes #1840.

FYI @742617000027

…patibility with, at least, TypeScript 4.7. Also add an "integration test" to ensure integrating web-api in a project with TS 4.7.2 works.
@filmaj filmaj added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Jul 4, 2024
@filmaj filmaj added this to the [email protected] milestone Jul 4, 2024
@filmaj filmaj requested a review from a team July 4, 2024 15:39
@filmaj filmaj self-assigned this Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.85%. Comparing base (e678aff) to head (972fd7b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1841   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files          35       35           
  Lines        7781     7781           
  Branches      318      318           
=======================================
  Hits         6369     6369           
  Misses       1400     1400           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 94.94% <ø> (ø)
cli-test 54.16% <ø> (ø)
oauth 76.53% <ø> (ø)
socket-mode 59.59% <ø> (ø)
web-api 96.57% <ø> (ø)
webhook 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj filmaj merged commit b284994 into main Jul 4, 2024
30 checks passed
@filmaj filmaj deleted the ts-47-compat branch July 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduced in 7.3.0: "Only named exports may use 'export type'"
1 participant