Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: @slack/[email protected]+cli.2.27.1 #1850

Merged
merged 1 commit into from
Jul 22, 2024
Merged

release: @slack/[email protected]+cli.2.27.1 #1850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@slack/cli-test",
"version": "0.2.1+cli.2.26.0",
"version": "0.2.2+cli.2.27.1",
"description": "Node.js bindings for the Slack CLI for use in automated testing",
"author": "Salesforce, Inc.",
"license": "MIT",
Expand Down
3 changes: 1 addition & 2 deletions packages/cli-test/src/cli/commands/platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,9 @@ export default {
return new Promise((resolve, reject) => {
// kill the shell process
shell.kill(proc).then(() => {

// Due to the complexity of gracefully shutting down processes on Windows / lack of interrupt signal support,
// we don't wait for the SLACK_TRACE_PLATFORM_RUN_STOP trace on Windows
if (process.platform === "win32") {
if (process.platform === 'win32') {
resolve();
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli-test/src/cli/shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export const shell = {
},
assembleShellEnv: function assembleShellEnv(): Record<string, string | undefined> {
const spawnedEnv = { ...process.env };
if (process.platform === "win32"){
if (process.platform === 'win32') {
spawnedEnv.PATH = process.env.PATH;
}
// Always enable test trace output
Expand Down