Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-test(feat): Added datastore command into the index #2061

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

cchensh
Copy link
Contributor

@cchensh cchensh commented Oct 2, 2024

Added datastore command into the index

@cchensh cchensh requested review from filmaj and vegeris October 2, 2024 19:03
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (943e153) to head (c1eb355).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2061   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files          38       38           
  Lines       10081    10083    +2     
  Branches      631      631           
=======================================
+ Hits         9249     9251    +2     
  Misses        820      820           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 95.69% <100.00%> (+<0.01%) ⬆️
oauth 77.39% <ø> (ø)
socket-mode 58.22% <ø> (ø)
web-api 96.89% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aww haha crucial detail

@cchensh cchensh merged commit 1ea24e2 into main Oct 2, 2024
30 checks passed
@cchensh cchensh deleted the cchen-add-datastore-to-index branch October 2, 2024 19:08
@cchensh cchensh added this to the [email protected] milestone Oct 2, 2024
@cchensh cchensh changed the title Added datastore command into the index cli-test(feat): Added datastore command into the index Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants