Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-api(feat): minor additions to some admin API response types #2071

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 7, 2024

also lint response type generation after running the script.

… response type generation after running the script.
@filmaj filmaj added semver:minor area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Oct 7, 2024
@filmaj filmaj self-assigned this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (829309e) to head (27735a0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2071   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files          38       38           
  Lines       10083    10083           
  Branches      631      631           
=======================================
  Hits         9251     9251           
  Misses        820      820           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 95.69% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 58.22% <ø> (ø)
web-api 96.89% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj filmaj added this to the [email protected] milestone Oct 7, 2024
@filmaj filmaj merged commit 01d9d2d into main Oct 7, 2024
30 checks passed
@filmaj filmaj deleted the web-api-update-resp-types branch October 7, 2024 19:00
mtjandra pushed a commit to mtjandra/node-slack-sdk that referenced this pull request Oct 16, 2024
mtjandra pushed a commit to mtjandra/node-slack-sdk that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant