Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-api(feat): add support for conversations.requestShared.list API #2072

Merged
merged 2 commits into from
Oct 7, 2024
Merged

web-api(feat): add support for conversations.requestShared.list API #2072

merged 2 commits into from
Oct 7, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 7, 2024

@filmaj filmaj added semver:minor enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Oct 7, 2024
@filmaj filmaj requested a review from a team October 7, 2024 19:22
@filmaj filmaj self-assigned this Oct 7, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (01d9d2d) to head (542dc03).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2072   +/-   ##
=======================================
  Coverage   91.74%   91.75%           
=======================================
  Files          38       38           
  Lines       10083    10093   +10     
  Branches      631      631           
=======================================
+ Hits         9251     9261   +10     
  Misses        820      820           
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 95.69% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 58.22% <ø> (ø)
web-api 96.89% <100.00%> (+<0.01%) ⬆️
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj filmaj merged commit 59f200a into main Oct 7, 2024
30 checks passed
@filmaj filmaj deleted the web-api-invite-list branch October 7, 2024 20:21
@seratch seratch added this to the [email protected] milestone Oct 8, 2024
mtjandra pushed a commit to mtjandra/node-slack-sdk that referenced this pull request Oct 16, 2024
@filmaj @mtjandra
web-api(feat): add support for conversations.requestShared.list API (…
5f20c92 
…slackapi#2072)
mtjandra pushed a commit to mtjandra/node-slack-sdk that referenced this pull request Oct 16, 2024
@filmaj @mtjandra
web-api(feat): add support for conversations.requestShared.list API (…
00de164 
…slackapi#2072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srajiang srajiang srajiang approved these changes

Assignees

@filmaj filmaj

Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` semver:minor
Projects
None yet
Milestone
[email protected]
Development

Successfully merging this pull request may close these issues.
3 participants
@filmaj @srajiang @seratch