feat(web-api): add new is_send_allowed optional parameter to assistant.threads.setStatus method
#2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tant.threads.setStatus` method
filmaj
added
semver:minor
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 38 38
Lines 10264 10264
Branches 646 646
=======================================
Hits 9426 9426
Misses 826 826
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
srajiang
reviewed
Oct 28, 2024
| @@ -8,6 +8,8 @@ export interface AssistantThreadsSetStatusArguments extends TokenOverridable { | |||
| status: string; | |||
| /** @description Message timestamp of the thread. */ | |||
| thread_ts: string; | |||
| /** @description Whether or not the user is allowed to send a message while the status is being displayed. Defaults to `false`. */ | |||
There was a problem hiding this comment.
I noticed that the default doesn't render properly on the site,
then went to api docs to inquire, and saw that you'd already asked about it ❤️ great minds!!
srajiang
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://api.slack.com/methods/assistant.threads.setStatus#arg_is_send_allowed
Relates to slackapi/python-slack-sdk#1577