Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-test): use powershell.exe as shell on windows #2082

Closed
wants to merge 10 commits into from

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 31, 2024

What changes if we use powershell when shelling out to the CLI on Windows? Will cut an RC from this branch to test and experiment.

@filmaj filmaj added semver:minor draft pkg:cli-test applies to `@slack/cli-test` labels Oct 31, 2024
@filmaj filmaj self-assigned this Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (1be7a9e) to head (a9af549).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2082      +/-   ##
==========================================
- Coverage   91.83%   91.13%   -0.71%     
==========================================
  Files          38       21      -17     
  Lines       10264     8683    -1581     
  Branches      646      562      -84     
==========================================
- Hits         9426     7913    -1513     
+ Misses        826      758      -68     
  Partials       12       12              
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test ?
oauth 77.39% <ø> (ø)
socket-mode 58.22% <ø> (ø)
web-api 96.88% <ø> (-0.01%) ⬇️
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj
Copy link
Contributor Author

filmaj commented Nov 1, 2024

Closing in favour of #2090

@filmaj filmaj closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft pkg:cli-test applies to `@slack/cli-test` semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant