Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!(cli-test): Use child_process spawn arguments properly, fixing JSON encoding on the command line on Windows #2090

Merged
merged 6 commits into from
Nov 4, 2024
Merged

feat!(cli-test): Use child_process spawn arguments properly, fixing JSON encoding on the command line on Windows #2090

merged 6 commits into from
Nov 4, 2024

Commits on Nov 1, 2024

  1. feat!(cli-test): use child_process spawn arguments properly, and esca… 

    …pe JSON for datastore commands.
    @filmaj
    filmaj committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    48087e4 View commit details
    Browse the repository at this point in the history

  2. revert version

    @filmaj
    filmaj committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    48ac92b View commit details
    Browse the repository at this point in the history

  3. add tests for windows vs other shell spawning behaviour

    @filmaj
    filmaj committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3235029 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Update packages/cli-test/src/cli/shell.ts 

    Co-authored-by: Michael Brooks <[email protected]>
    @filmaj @mwbrooks
    filmaj and mwbrooks authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    4f41569 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. elaborate on explanation for windows cmd.exe spawning workaround

    @filmaj
    filmaj committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bcbc1fd View commit details
    Browse the repository at this point in the history

  2. document escapeJSON datastore helper function

    @filmaj
    filmaj committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4ec7f60 View commit details
    Browse the repository at this point in the history