Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-test): include expected test trace outputs for the "env" subcommands #2097

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Nov 21, 2024

Summary

This PR adds the expected test trace outputs for the env command.

These are labelled as "variables" to match internal CLI structure - var is an alias of env - but that can be updated!

Requirements

@zimeg zimeg added semver:minor pkg:cli-test applies to `@slack/cli-test` labels Nov 21, 2024
@zimeg zimeg added this to the [email protected] milestone Nov 21, 2024
@zimeg zimeg requested a review from mwbrooks November 21, 2024 02:43
@zimeg zimeg self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (278514f) to head (dff7839).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2097   +/-   ##
=======================================
  Coverage   91.65%   91.66%           
=======================================
  Files          38       38           
  Lines       10311    10315    +4     
  Branches      647      647           
=======================================
+ Hits         9451     9455    +4     
  Misses        848      848           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.48% <100.00%> (+0.01%) ⬆️
oauth 77.39% <ø> (ø)
socket-mode 58.22% <ø> (ø)
web-api 96.88% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@zimeg
Copy link
Member Author

zimeg commented Nov 22, 2024

@filmaj @mwbrooks Thank y'all both for the reviews! This is set to land in the next CLI release, so I think it's alright to merge now and tag later.

I plan to follow up with this and perhaps a few other changes to @slack/cli-test in neartimes 👁️‍🗨️

@zimeg zimeg merged commit 7b49582 into main Nov 22, 2024
57 checks passed
@zimeg zimeg deleted the zimeg-cli-test-feat-trace-env-cmd branch November 22, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:cli-test applies to `@slack/cli-test` semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants