Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTM_CONNECTION_OPENED event name #446

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Conversation

marclemagne
Copy link
Contributor

Summary

Fixes a typo in README for RTM_CONNECTION_OPEN to be RTM_CONNECTION_OPENED.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Dec 31, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

Merging #446 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage    89.1%   89.25%   +0.14%     
==========================================
  Files          44       44              
  Lines        1258     1275      +17     
  Branches      190      194       +4     
==========================================
+ Hits         1121     1138      +17     
  Misses        137      137
Impacted Files Coverage Δ
lib/clients/transports/request.js 90.9% <0%> (+4.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36191ab...2276c1d. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented Jan 22, 2018

good catch!!

@aoberoi aoberoi merged commit a6c7283 into slackapi:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants