Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds subscribing to presence information #454

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Jan 23, 2018

Summary

Documents the batch_presence_aware option for rtm.start().

Adds an example of subscribing to presence events to the RTM API guide.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #454 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   89.12%   89.12%           
=======================================
  Files          44       44           
  Lines        1260     1260           
  Branches      190      190           
=======================================
  Hits         1123     1123           
  Misses        137      137
Impacted Files Coverage Δ
lib/clients/rtm/client.js 84.21% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c7283...9edfc55. Read the comment docs.

Copy link
Contributor

@Roach Roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aoberoi aoberoi merged commit 1dfe3ea into slackapi:master Jan 23, 2018
@aoberoi aoberoi deleted the presence-sub-docs branch January 23, 2018 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants