Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @types/node from devDependencies to dependencies #518

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Mar 21, 2018

Summary

Fixes #514

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #518   +/-   ##
======================================
  Coverage    79.7%   79.7%           
======================================
  Files           6       6           
  Lines         271     271           
  Branches       42      42           
======================================
  Hits          216     216           
  Misses         38      38           
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46bab9...b940bee. Read the comment docs.

@aoberoi aoberoi merged commit b957324 into slackapi:master Mar 21, 2018
@aoberoi aoberoi deleted the tslib-node-dep branch March 21, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants