Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file mode of README.md #1328

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

WOnder93
Copy link
Contributor

Summary

README.md should not be executable - fix the mode bits.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)
  • none of the above

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2023

CLA assistant check
All committers have signed the CLA.

README.md should not be executable - fix the mode bits.

Signed-off-by: Ondrej Mosnáček <[email protected]>
@seratch seratch added enhancement M-T: A feature request for new functionality Version: 3x labels Feb 13, 2023
@seratch seratch added this to the 3.20.0 milestone Feb 13, 2023
@seratch seratch self-assigned this Feb 13, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1328 (4dcdfbe) into main (1ed78c6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1328   +/-   ##
=======================================
  Coverage   85.40%   85.41%           
=======================================
  Files         111      111           
  Lines       11394    11394           
=======================================
+ Hits         9731     9732    +1     
+ Misses       1663     1662    -1     
Impacted Files Coverage Δ
slack_sdk/socket_mode/builtin/internals.py 72.53% <0.00%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit dcacdc1 into slackapi:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants