Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1369 ImageBlock title parsing defaults to incorrect behaviour when given a string #1374

Merged
merged 1 commit into from
May 27, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented May 26, 2023

Summary

This pull request resolves #1369

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels May 26, 2023
@seratch seratch added this to the 3.21.4 milestone May 26, 2023
@seratch seratch requested a review from zimeg May 26, 2023 06:35
@seratch seratch self-assigned this May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1374 (c45f93d) into main (3afc31a) will increase coverage by 0.01%.
The diff coverage is 92.30%.

❗ Current head c45f93d differs from pull request most recent head a6df459. Consider uploading reports for the commit a6df459 to get more accurate results

@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
+ Coverage   85.55%   85.57%   +0.01%     
==========================================
  Files         111      111              
  Lines       11570    11582      +12     
==========================================
+ Hits         9899     9911      +12     
  Misses       1671     1671              
Impacted Files Coverage Δ
slack_sdk/models/blocks/blocks.py 96.60% <92.30%> (-0.24%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and handles errors so well! Tested this without a title too and found no problems! 🚀

@seratch seratch merged commit 027a287 into slackapi:main May 27, 2023
@seratch seratch deleted the issue-1369-image-block-title branch May 27, 2023 00:38
@seratch seratch modified the milestones: 3.21.4, 3.22.0 May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageBlock title parsing defaults to incorrect behaviour when given a string
2 participants