Skip to content

Commit

Permalink
update rules to remove python2 requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
slamdev committed Apr 15, 2023
1 parent a5a14ec commit cd95c90
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 9 deletions.
3 changes: 3 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
# Settings that apply only to CI are in .github/workflows/ci.bazelrc
build --nolegacy_external_runfiles

# https://github.com/bazelbuild/rules_docker/pull/2068
build --@io_bazel_rules_docker//transitions:enable=false

# Load any settings specific to the current user.
# .bazelrc.user should appear in .gitignore so that settings are not shared with team members
# This needs to be last statement in this
Expand Down
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
4.2.1
5.1.1
# The first line of this file is used by Bazelisk and Bazel to be sure
# the right version of Bazel is used to build and test this repo.
# This also defines which version is used on CI.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
# https://github.com/bazelbuild/rules_docker/issues/1524
# https://github.com/bazelbuild/rules_docker/issues/1438
# - windows-latest
bazel: [ 4.2.1, 5.0.0-pre.20211011.2 ]
bazel: [ 5.1.1 ]
# The type of runner that the job will run on
runs-on: ${{ matrix.os }}

Expand Down
3 changes: 2 additions & 1 deletion docs/rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Defines an imported helm chart.
<pre>
helm_install(<a href="#helm_install-name">name</a>, <a href="#helm_install-atomic">atomic</a>, <a href="#helm_install-chart">chart</a>, <a href="#helm_install-cleanup_on_fail">cleanup_on_fail</a>, <a href="#helm_install-create_namespace">create_namespace</a>, <a href="#helm_install-description">description</a>,
<a href="#helm_install-disable_openapi_validation">disable_openapi_validation</a>, <a href="#helm_install-dry_run">dry_run</a>, <a href="#helm_install-force">force</a>, <a href="#helm_install-images">images</a>, <a href="#helm_install-namespace">namespace</a>, <a href="#helm_install-no_hooks">no_hooks</a>, <a href="#helm_install-release_name">release_name</a>,
<a href="#helm_install-template_output">template_output</a>)
<a href="#helm_install-skip_crds">skip_crds</a>, <a href="#helm_install-template_output">template_output</a>)
</pre>

Defines a helm install execution.
Expand All @@ -80,6 +80,7 @@ Defines a helm install execution.
| <a id="helm_install-namespace"></a>namespace | Namespace scope for this reques. | String | optional | "" |
| <a id="helm_install-no_hooks"></a>no_hooks | Prevent hooks from running during install\upgrade | Boolean | optional | False |
| <a id="helm_install-release_name"></a>release_name | Release name used by helm. | String | required | |
| <a id="helm_install-skip_crds"></a>skip_crds | No CRDs will be installed | Boolean | optional | False |
| <a id="helm_install-template_output"></a>template_output | Filename to dump the rendered chart | <a href="https://bazel.build/docs/build-ref.html#labels">Label</a> | optional | |


Expand Down
5 changes: 2 additions & 3 deletions helm/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ def rules_helm_dependencies():
maybe(
http_archive,
name = "io_bazel_rules_docker",
sha256 = "92779d3445e7bdc79b961030b996cb0c91820ade7ffa7edca69273f404b085d5",
strip_prefix = "rules_docker-0.20.0",
urls = ["https://github.com/bazelbuild/rules_docker/releases/download/v0.20.0/rules_docker-v0.20.0.tar.gz"],
sha256 = "b1e80761a8a8243d03ebca8845e9cc1ba6c82ce7c5179ce2b295cd36f7e394bf",
urls = ["https://github.com/bazelbuild/rules_docker/releases/download/v0.25.0/rules_docker-v0.25.0.tar.gz"],
)
maybe(
http_archive,
Expand Down
15 changes: 12 additions & 3 deletions internal_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,23 @@ load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")

def rules_helm_internal_deps():
"Fetch deps needed for local development"
maybe(
http_archive,
name = "rules_license",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/rules_license/releases/download/0.0.1/rules_license-0.0.1.tar.gz",
],
sha256 = "4865059254da674e3d18ab242e21c17f7e3e8c6b1f1421fffa4c5070f82e98b5",
)

maybe(
http_archive,
name = "rules_pkg",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.2.4/rules_pkg-0.2.4.tar.gz",
"https://github.com/bazelbuild/rules_pkg/releases/download/0.2.4/rules_pkg-0.2.4.tar.gz",
"https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.7.1/rules_pkg-0.7.1.tar.gz",
"https://github.com/bazelbuild/rules_pkg/releases/download/0.7.1/rules_pkg-0.7.1.tar.gz",
],
sha256 = "4ba8f4ab0ff85f2484287ab06c0d871dcb31cc54d439457d28fd4ae14b18450a",
sha256 = "451e08a4d78988c06fa3f9306ec813b836b1d076d0f055595444ba4ff22b867f",
)

maybe(
Expand Down

0 comments on commit cd95c90

Please sign in to comment.