ReferencedNameHelper: Fixed searching of class references in heredoc

slevomat · Mar 1, 2022 · bef66a4 · bef66a4
1 parent c1d5942
commit bef66a4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/SlevomatCodingStandard/Helpers/ReferencedNameHelper.php b/SlevomatCodingStandard/Helpers/ReferencedNameHelper.php
@@ -135,6 +135,7 @@ private static function createAllReferencedNames(File $phpcsFile, int $openTagPo
 		$beginSearchAtPointer = $openTagPointer + 1;
 		$nameTokenCodes = TokenHelper::getNameTokenCodes();
 		$nameTokenCodes[] = T_DOUBLE_QUOTED_STRING;
+		$nameTokenCodes[] = T_HEREDOC;
 
 		$tokens = $phpcsFile->getTokens();
 		while (true) {

diff --git a/tests/Helpers/ReferencedNameHelperTest.php b/tests/Helpers/ReferencedNameHelperTest.php
@@ -67,6 +67,7 @@ public function testGetAllReferencedNames(): void
 			['STR_PAD_RIGHT', false, true],
 			['EnumType', false, false],
 			['UrlGeneratorInterface', false, false],
+			['ClassInHeredoc', false, false],
 			['ClassInDoubleQuote', false, false],
 		];
 

diff --git a/tests/Helpers/data/lotsOfReferencedNames.php b/tests/Helpers/data/lotsOfReferencedNames.php
@@ -177,6 +177,10 @@ public function generateRoute($router): string
 	}
 }
 
+<<<XML
+	<string>Hello world and {$this->wrap(ClassInHeredoc::EXAMPLE)}</string>
+XML;
+
 "foo {$db->quote(ClassInDoubleQuote::SOME_CONSTANT)}";
 "foo $db->quote(FakeClassInDoubleQuote::SOME_CONSTANT)";
-Original file line number
+Diff line change
@@ Expand Up / @@ -177,6 +177,10 @@ public function generateRoute($router): string @@
     	}
     }
+    <<<XML
+    	<string>Hello world and {$this->wrap(ClassInHeredoc::EXAMPLE)}</string>
+    XML;
     "foo {$db->quote(ClassInDoubleQuote::SOME_CONSTANT)}";
     "foo $db->quote(FakeClassInDoubleQuote::SOME_CONSTANT)";
@@ Expand Down @@