Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Typos in CI #1630

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Run Typos in CI #1630

merged 1 commit into from
Oct 8, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Oct 7, 2023

Needs #1629 to succeed.

uses: "actions/checkout@v3"

- name: "Search for misspellings"
uses: "crate-ci/typos@master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use v1 or something like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they don't have this kind of tag.
https://github.com/crate-ci/typos/tags
Typos is getting better at typos fast.

BTW I find their GHA action terrible.
Using this instead https://github.com/szepeviktor/byte-level-care/blob/f1c750a0424ab8a0b7e96cd253f8cb3973b324c6/.github/workflows/spelling.yml#L31-L50

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I would use the latest tag v1.16.17

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 🍏

@kukulich
Copy link
Contributor

kukulich commented Oct 8, 2023

Thanks.

@kukulich kukulich merged commit 34c47b1 into slevomat:master Oct 8, 2023
36 checks passed
@szepeviktor szepeviktor deleted the add-typos branch October 8, 2023 08:13
@szepeviktor
Copy link
Contributor Author

Glad to meet your bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants