Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create extendable sync states #1854

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

tonai
Copy link
Contributor

@tonai tonai commented Sep 6, 2024

Extends createSyncState to allow custom external synchronization.

the goal is to solve the problem with synchronization using static builds:

This can be a quick solution before migrating on Nuxt.

I am already working on an addon that will allow synchronization of shared and drawings states (and possibly others).

@tonai tonai requested review from antfu and KermanX September 6, 2024 17:00
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit d77ac03
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/66db351d25106600081b5b90
😎 Deploy Preview https://deploy-preview-1854--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Sep 6, 2024

Open in Stackblitz

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1854

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1854

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1854

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1854

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1854

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1854

commit: d77ac03

@tonai
Copy link
Contributor Author

tonai commented Sep 26, 2024

For information I also updated my slidev poll addon https://github.com/Smile-SA/slidev-component-poll that uses createSyncState to now let https://github.com/Smile-SA/slidev-addon-sync handle the synchronization for static builds and it works just fine.
I am just waiting for this PR to be merged and a new release to be published to publish both slidev-component-poll and slidev-addon-sync with the correct slidev peerDependencies

@antfu antfu merged commit 599738c into main Sep 27, 2024
20 checks passed
@antfu antfu deleted the feat/extendable-sync-states branch September 27, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants