Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add match-wide preds and make them default #157

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Add match-wide preds and make them default #157

merged 2 commits into from
Nov 30, 2022

Conversation

zusorio
Copy link
Collaborator

@zusorio zusorio commented Nov 28, 2022

This should resolve #156 but it's currently untested and not the most elegant.

@slmnio slmnio marked this pull request as ready for review November 30, 2022 22:16
@slmnio slmnio self-requested a review November 30, 2022 22:17
@slmnio slmnio added section: broadcast Relates to broadcast overlays or pages section: server Relates to server or node scripts labels Nov 30, 2022
slmnio
slmnio approved these changes Nov 30, 2022
View reviewed changes
Copy link
Owner

@slmnio slmnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but looks good 👍

@slmnio slmnio merged commit 9fedbca into slmnio:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slmnio slmnio slmnio approved these changes

Assignees

@zusorio zusorio

Labels
section: broadcast Relates to broadcast overlays or pages section: server Relates to server or node scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the option to do predictions by match instead of map
2 participants
@zusorio @slmnio