Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tally transmitter more visually appealing #171

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

zusorio
Copy link
Collaborator

@zusorio zusorio commented Jan 22, 2023

  • I reused and slightly modified the UI from the tally viewer
  • I also removed an unused parameter
    image
    image

Copy link
Owner

@slmnio slmnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the design, I think it improves it a lot. Few notes on the disconnected state that we talked about before.

@zusorio
Copy link
Collaborator Author

zusorio commented Jan 23, 2023

I added error messages and changed the icon in c63a1fe, here's what it looks like
image

Copy link
Owner

@slmnio slmnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look great!

@slmnio slmnio merged commit 20dc6b7 into slmnio:master Jan 23, 2023
@zusorio zusorio deleted the design-tally-transmitter branch January 23, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants