Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from vue cli to vite #176

Merged
merged 11 commits into from
Mar 9, 2023
Merged

Migrate from vue cli to vite #176

merged 11 commits into from
Mar 9, 2023

Conversation

zusorio
Copy link
Collaborator

@zusorio zusorio commented Feb 6, 2023

This PR migrates the slmn.gg frontend from vue-cli to vite by using this guide.

The main changes are:

  • Environment variables now start with VITE_ instead of VUE_APP_
  • Environment variables are accessed from import.meta.env instead of process.env
  • Babel was removed

@slmnio
Copy link
Owner

slmnio commented Feb 7, 2023

This looks good, I've had a play with it to try and break it and everything looks like it should be in working order. I might try to run it on the main server first, then we can merge it in completely.

@slmnio slmnio self-requested a review February 7, 2023 03:42
website/package.json Outdated Show resolved Hide resolved
@slmnio
Copy link
Owner

slmnio commented Feb 7, 2023

I used the build-stage action on the server, so dev.slmn.gg is live with it right now. It looks like Vue doesn't know that it's in developer mode, but the site does. I wonder if the stage building process can tell Vue to build in development mode so things are still accessible compared to the full prod build.
image

@zusorio
Copy link
Collaborator Author

zusorio commented Feb 7, 2023

I've force-enabled vue devtools in staging in 80899b5, i can take a look at fs next

@slmnio
Copy link
Owner

slmnio commented Feb 7, 2023

Nice stuff so far

@zusorio
Copy link
Collaborator Author

zusorio commented Feb 9, 2023

Recoloring works again after replacing jimp with image-js

@slmnio
Copy link
Owner

slmnio commented Feb 9, 2023

Looks great

@zusorio zusorio requested a review from slmnio February 12, 2023 23:22
Copy link
Owner

@slmnio slmnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending it

@slmnio slmnio merged commit e9b539c into slmnio:master Mar 9, 2023
@zusorio zusorio deleted the migrate-to-vite branch May 10, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants