Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Player History Scene #92

Merged
merged 16 commits into from
Jan 18, 2022
Merged

Add Player History Scene #92

merged 16 commits into from
Jan 18, 2022

Conversation

JJ1898
Copy link
Contributor

@JJ1898 JJ1898 commented Jan 13, 2022

Add a scene that displays a player's career history, potentially expandable to display things such as favorite hero or career win percentage
image

Copy link
Owner

@slmnio slmnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little things to clean up but it otherwise looks good. Might be worth posting your screenshot with a hero image in here too.

website/src/components/broadcast/PlayerHero.vue Outdated Show resolved Hide resolved
website/src/components/broadcast/PlayerHero.vue Outdated Show resolved Hide resolved
website/src/components/broadcast/PlayerHero.vue Outdated Show resolved Hide resolved
website/src/components/broadcast/PlayerHero.vue Outdated Show resolved Hide resolved
@JJ1898
Copy link
Contributor Author

JJ1898 commented Jan 18, 2022

Here's how the scene looks like as of 758f527
image
styling for edge case teams is still needed

@slmnio
Copy link
Owner

slmnio commented Jan 18, 2022

image

@slmnio slmnio merged commit ced7f3b into slmnio:master Jan 18, 2022
@JJ1898 JJ1898 deleted the player-history-scene branch January 20, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants