Cleanup legacy ipython code; remove packaging and colorama as deps

sloria · Jan 30, 2024 · 01092cc · 01092cc
1 parent 5f75bf0
commit 01092cc
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 181 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,7 +1,7 @@
 Changelog
 ---------
 
-5.0.0 (unreleased)
+5.0.0 (2024-01-09)
 ******************
 
 Features:

diff --git a/doitlive/ipython/__init__.py b/doitlive/ipython/__init__.py
@@ -1,23 +1,9 @@
-import packaging.version
-
-
-def is_modern_ipython():
+def start_ipython_player(commands, speed):
     try:
-        import IPython
+        from doitlive.ipython.app import PlayerTerminalIPythonApp
     except ImportError:
         raise RuntimeError("ipython blocks require IPython to be installed")
 
-    return packaging.version.parse(IPython.__version__) >= packaging.version.parse(
-        "7.0.0"
-    )
-
-
-def start_ipython_player(commands, speed):
-    if is_modern_ipython():
-        from doitlive.ipython.app import PlayerTerminalIPythonApp
-    else:
-        from doitlive.ipython.legacy_app import PlayerTerminalIPythonApp
-
     PlayerTerminalIPythonApp.commands = commands
     PlayerTerminalIPythonApp.speed = speed
     PlayerTerminalIPythonApp.launch_instance()
diff --git a/doitlive/ipython/legacy_app.py b/doitlive/ipython/legacy_app.py
diff --git a/setup.py b/setup.py
@@ -8,13 +8,8 @@
     "click>=8.0,<9",
     "click-completion>=0.3.1",
     "click-didyoumean>=0.0.3",
-    "packaging",
 ]
 
-if "win32" in str(sys.platform).lower():
-    # Terminal colors for Windows
-    INSTALL_REQUIRES.append("colorama>=0.2.4")
-
 EXTRAS_REQUIRE = {
     "tests": ["pytest", "IPython"],
     "lint": [