-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: archive #163
base: main
Are you sure you want to change the base?
Feature: archive #163
Conversation
@dev-viinz is attempting to deploy a commit to the f1-dash Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @dev-viinz sorry for the very late response. From the first look it seems to be going in the right direction. But I was not able to take a look at everything. |
No worries @slowlydev, I updated the visuals yesterday, so whenever you get a chance to look is fine ^^ |
I believe it's ready for a first review, but no rush, we're all doing this in our free time :) |
I think for now this is a starting point, the rust api call is already a good start. The UI could still use some improvements but I think thats mostly personal preference (as most of the UI decisions are in f1-dash). One thing I would change is the year selection, this segmented select looks good but over the years it might look cluttered and maybe a simple dropdown/select would be better. What do you think? How should we continue this PR? |
I've enabled maintainers to contribute to my branch, so any UI preferences you want to make yourself, you can :) I agree that with more years we'd get a cluttered interface quickly, so I added a dropdown. Let me know what you think ^^ |
this is a very early WIP for an archive page (from where i want to enable viewing replays further down the road)
i'm not sure though wether i'm doing any of this correctly, so i wanted to get some early feedback if possible :)
@slowlydev