break: Revert "chore: Revert "fix: upload-artifact and download-artifact v4"" #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonpetgrave64
requested review from
laurentsimon,
joshuagl and
kpk47
as code owners
laurentsimon
approved these changes
Apr 2, 2024
ramonpetgrave64
changed the title
…#3398)" This reverts commit 90f2eb1. Signed-off-by: Ramon Petgrave <[email protected]>
ramonpetgrave64
force-pushed
the
revert-3398-revert-3312-ramonpetgrave64-upload-download-artifact-v4
branch
from
2368781 to
51f2ca0
Compare
Signed-off-by: Ramon Petgrave <[email protected]>
laurentsimon
reviewed
Apr 3, 2024
| @@ -36,6 +36,7 @@ jobs: | |||
| # echo "2e0390eb024a52963db7b95e84a9c2b12c004054a7bad9a97ec0c7c89d4681d2 binary-name" | base64 -w0 | |||
| base64-subjects: "MmUwMzkwZWIwMjRhNTI5NjNkYjdiOTVlODRhOWMyYjEyYzAwNDA1NGE3YmFkOWE5N2VjMGM3Yzg5ZDQ2ODFkMiAgICBiaW5hcnktbmFtZQo=" | |||
| compile-generator: true | |||
| provenance-name: build.intoto.jsonl | |||
There was a problem hiding this comment.
ah good catch! Were these effectively colluding with each other?
There was a problem hiding this comment.
Yes, which upload-artifact@v4 doesn't allow anymore.
There was a problem hiding this comment.
Before, I hadn't realized that this particular test was also failing.
ramonpetgrave64
deleted the
revert-3398-revert-3312-ramonpetgrave64-upload-download-artifact-v4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3398
Following up with