Skip to content

Commit

Permalink
autocomplete [nfc]: Move down MentionAutocompleteView.computeResults
Browse files Browse the repository at this point in the history
This will result in a more logical order of the class members.
  • Loading branch information
sm-sayedi committed Jan 26, 2025
1 parent 96b476b commit f70e0df
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions lib/model/autocomplete.dart
Original file line number Diff line number Diff line change
Expand Up @@ -439,23 +439,6 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
final Narrow narrow;
final List<User> sortedUsers;

@override
Future<List<MentionAutocompleteResult>?> computeResults() async {
final results = <MentionAutocompleteResult>[];
if (await filterCandidates(filter: _testUser,
candidates: sortedUsers, results: results)) {
return null;
}
return results;
}

MentionAutocompleteResult? _testUser(MentionAutocompleteQuery query, User user) {
if (query.testUser(user, store.autocompleteViewManager.autocompleteDataCache)) {
return UserMentionAutocompleteResult(userId: user.userId);
}
return null;
}

static List<User> _usersByRelevance({
required PerAccountStore store,
required Narrow narrow,
Expand Down Expand Up @@ -615,6 +598,23 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
return userAName.compareTo(userBName); // TODO(i18n): add locale-aware sorting
}

@override
Future<List<MentionAutocompleteResult>?> computeResults() async {
final results = <MentionAutocompleteResult>[];
if (await filterCandidates(filter: _testUser,
candidates: sortedUsers, results: results)) {
return null;
}
return results;
}

MentionAutocompleteResult? _testUser(MentionAutocompleteQuery query, User user) {
if (query.testUser(user, store.autocompleteViewManager.autocompleteDataCache)) {
return UserMentionAutocompleteResult(userId: user.userId);
}
return null;
}

@override
void dispose() {
store.autocompleteViewManager.unregisterMentionAutocomplete(this);
Expand Down

0 comments on commit f70e0df

Please sign in to comment.