-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make invocation number accessible #230
Make invocation number accessible #230
Conversation
64940a1
to
1e6b0f0
Compare
implements #216 |
config.md needs an example of how to use %(invocations) around line 220, i have added a description but i couldn't think of a good example |
The test currently only results on one data point being produced? |
for loop in issue_216_vm.py is needed otherwise it causes the following error
E AttributeError: 'NoneType' object has no attribute 'unit' /Users/naomigrew/Documents/ReBench/rebench/model/data_point.py:55: AttributeError |
Create issue_216.conf Create issue_216_test.py Create issue_216.data give a value to invocation if in cmdline add functions to store and get the updated cmdline add invocation as a command
Co-authored-by: Stefan Marr <[email protected]>
Co-authored-by: Stefan Marr <[email protected]>
Co-authored-by: Stefan Marr <[email protected]>
Co-authored-by: Stefan Marr <[email protected]>
1b2512f
to
b73bcf0
Compare
43c5468
to
f1af604
Compare
f1af604
to
5b147cd
Compare
…ny adapter applied The adapters may introduce arbitrary data, for instance the TimeAdapter may introduces a string that encodes how to output MaxRSS using %M. Since all this can be confused with our variables, we need to use a new `. cmdline_for_next_invocation()` method when aquiring the command.
7574deb
to
02b8fe9
Compare
Thanks for preparing this. I added an example to the documentation, simplified your test quite a bit so that it really just prints out the current invocation number, and configure it to invoke the run 4 times, which checks what we want to check, and makes the test pass. Though, I noticed that we can't really just expand the variable in the executor, because this is after we appended all kind of other, possibly arbitrary data to the command line. |
No description provided.