Defining a Schema for ReBench configuration files #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Thus, we have to be explicit about the list, even for single item lists. Signed-off-by: Stefan Marr <[email protected]>
The test was removed with 4ff9cf9 Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
issue-6-schema-validation
branch
from
fda4972 to
74e10e2
Compare
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
The result is a bit more readable Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
issue-6-schema-validation
branch
from
3faceaa to
ce054ed
Compare
Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of approaching #6 (warning about unused stuff in config files) as well as in support of #66 (improving documentation), this PR adds a schema that can be used to validate ReBench's configuration files.
Currently, it includes a number of todos for cleanup, clarification, etc. So, pretty much work in progress. The
experimentsdefinition is also not yet at a point where it covers all relevant use cases.Overall it is a little stricter, but is able to validate all test files I found with only minor changes (for instance renaming of old stuff), or avoiding using scalars where lists are expected (it's a little sad that this simplification might not be possible in some cases though).