Improve error messages #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
smarr
commented
Jul 3, 2018
•
smarr
commented
- restructure UI to avoid redundant output, by being able to know what has been printed last
- interact with spinner, to avoid over-writing output
- failing runs indicate run id, command
- low mean errors indicate run id, command
Signed-off-by: Stefan Marr <[email protected]>
Repository owner
deleted a comment
Jul 8, 2018
Repository owner
deleted a comment
Jul 8, 2018
Repository owner
deleted a comment
Jul 8, 2018
Repository owner
deleted a comment
Jul 8, 2018
Repository owner
deleted a comment
Jul 8, 2018
- run info is now printed exactly once - output should be visually grouped - a UI instance manages the output - output now interacts with spinner to get correct output and clean out spinner before printing - added a dummy UI for tests Signed-off-by: Stefan Marr <[email protected]>
…builds - low mean warning should only be given when run didn’t fail - runs without samples should be indicated as failed - capture and report output from build on error Signed-off-by: Stefan Marr <[email protected]>
- simply pass it on - and init once we have the value - avoids having to set ui object after construction Signed-off-by: Stefan Marr <[email protected]>
This was referenced Jul 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.