Added method for graphical representation of Truffle Methods #110
Conversation
src/som/VM.java
Outdated
| @@ -31,15 +35,14 @@ | |||
| import som.interpreter.actors.SFarReference; | |||
| import som.interpreter.actors.SPromise; | |||
| import som.interpreter.actors.SPromise.SResolver; | |||
| import som.primitives.processes.ChannelPrimitives; | |||
There was a problem hiding this comment.
This removal looks suspicious. Is this intended?
src/som/VM.java
Outdated
| @@ -86,7 +89,7 @@ public static void setEngine(final PolyglotEngine e) { | |||
|
|
|||
| private int lastExitCode = 0; | |||
| private volatile boolean shouldExit = false; | |||
| private final VmOptions options; | |||
| private final VMOptions options; | |||
There was a problem hiding this comment.
This change looks like it might be the result of having worked with an earlier version. I recently renamed VmOptions.
src/som/VM.java
Outdated
| public VM(final String[] args, final boolean avoidExitForTesting) throws IOException { | ||
| vm = this; | ||
|
|
||
| this.avoidExitForTesting = avoidExitForTesting; | ||
| options = new VmOptions(args); | ||
| objectSystem = new ObjectSystem(new SourcecodeCompiler(), structuralProbe); | ||
| objectSystem.loadKernelAndPlatform(options.platformFile, options.kernelFile); |
There was a problem hiding this comment.
Hm, why is the loading of kernel and platform removed? Is this intentional?
src/som/VM.java
Outdated
| } catch (IOException e) { | ||
| VM.errorPrint("Failed to setup coverage tracking: " + e.getMessage()); | ||
| } | ||
| cov.setRepoToken(vmOptions.coverallsRepoToken); |
There was a problem hiding this comment.
Likely another set of unintended changes.
src/som/VM.java
Outdated
| @@ -377,8 +405,6 @@ public static void resetClassReferences(final boolean callFromUnitTest) { | |||
| ThreadingModule.ConditionClass = null; | |||
| ThreadingModule.ConditionClassId = null; | |||
|
|
|||
| ChannelPrimitives.resetClassReferences(); | |||
|
Thanks, looks good will test it tomorrow! |
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
|
@VAISHALI-DHANOA thanks again for the pull request. I simplified it a bit, also to avoid showing the same methods over and over again in IGV. And, I added a switch to the launcher script. So, if you got IGV running, and you execute |
This change adds support to show methods directly after parsing in IGV.
This can be used with the
-im/--igv-parsed-methodsoptions on thesomscript.