Implement message cascade #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
the
enhancement
This change introduces support for Smalltalk message cascades, i.e., syntax to send multiple messages to the same receiver be listing them with ; as separator. - add lexing of semicolon - includes basic tests - uses a normal immutable local to store the receiver, should perhaps become an internal variable instead. Benefit of local is that we see it in the debugger - I decided against an implementation with a separate node, because it would require introducing an executeWithReceiver method, which seems a more substantial change than simply desugaring into existing constructs - the replacing of the lastReceiver is a bit of a hack, and requires the previous message to adopt its children during parsing. However, this seems to be a simpler solution than delaying the assembly of those expressions Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
ns-message-cascades
branch
from
497053e
to
793eb6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces support for Smalltalk message cascades, i.e., syntax to send multiple messages to the same receiver by listing them with
;as separator.I decided against an implementation with a separate node, because it would require introducing an executeWithReceiver method, which seems a more substantial change than simply desugaring into existing constructs.
Replacing the lastReceiver is a bit of a hack, and requires the previous message to adopt its children during parsing. However, this seems to be a simpler solution than delaying the assembly of those expressions.