Improve Files module #220
Merged
Improve Files module #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
the
enhancement
smarr
force-pushed
the
file-module-improvements
branch
from
79ae22a
to
da8107d
Compare
Repository owner
deleted a comment
Feb 11, 2018
- fix imports in FileTests, no abbreviations - added test for the case of file not being found Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- avoid issues with invoking `som` from other directories Signed-off-by: Stefan Marr <[email protected]>
- using the path of the module allows us to run the tests from arbitrary directories Signed-off-by: Stefan Marr <[email protected]>
Setting an invalid access mode is considered an error an should fail as early as possible. - add documentation of supported access modes. Use simple symbols with camelCase spelling, as practice for everything else. - invalid access mode will raise an ArgumentError on setting it - make effort to have a nice error in that case Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
file-module-improvements
branch
from
200440e
to
95f5359
Compare
Repository owner
deleted a comment
Feb 15, 2018
|
@daumayr, I did more work on this. Would be good if you could review, especially to know whether you foresee any issues with what you need. |
|
@Richard-Roberts where's the review then? |
daumayr
approved these changes
Feb 16, 2018
core-lib/Files.ns
Outdated
| public open: mode <Symbol> ifFail: err <[:IOException | X def]> ^ <FileDescriptor | X> = ( | ||
| (* Open file with given access mode. | ||
| Access mode can be #read, #write, or #readWrite. *) | ||
| public open: mode <Symbol> ifFail: errBlock <[:Symbol | X def]> ^ <FileDescriptor | X> = ( | ||
| (* Modes: #read, #write, #readWrite *) |
There was a problem hiding this comment.
i guess thats no longer needed?
There was a problem hiding this comment.
Why? Think it is good practice to provide comments to all methods.
Ideally, VS code is going to show them at some point. (Think we only need to track them during parsing, if we don't do it yet, and then show them on the corresponding request. should be pretty simple)
There was a problem hiding this comment.
i mean the old one, the content is in the new one, so redundant
There was a problem hiding this comment.
aaah, now I see it, yes :) thanks
Signed-off-by: Stefan Marr <[email protected]>
…referably to indicate failure causes in blocks Signed-off-by: Stefan Marr <[email protected]>
Repository owner
deleted a comment
Feb 16, 2018
Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
file-module-improvements
branch
from
586de9b
to
00bb6b6
Compare
Repository owner
deleted a comment
Feb 16, 2018
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
|
Going to merge this once CI on GitLab/Brussels finished successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to improve test coverage, correctness, style, API, and functionality of the Files.ns module.
Main Changes
#read,#write,#readWrite, add documentationSFileDescriptorIncidental Changes
ClassDefinitionMirror>>#filePathto be able to access the file path of a modulesomand JaCoCo support robust to different current working directory