Move Actor mailbox loop to Truffle #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- this does not seem to be beneficial (not extensively benchmarked though) - problem is that we get too many different call targets - so, looking through list of cached items becomes expensive Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
smarr
added
the
enhancement
|
@daumayr, I started moving some of the things we did for the paper into the main branch. |
|
@smarr, I had a look on the changes, they look good to me. |
|
Thank you. It's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the loop that iterates over the messages in a mailbox into Truffle.
This is technically not an optimization in itself, but enables future optimization, because it gives more control over for instance tracing operations.
The PR contains also a number of smaller cleanups.
For reference, I included the code that adds caching for the methods of messages.
However, there are even for simple programs too many messages, so this is not useful, and therefore reverted.