Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMM'18 Demo and Kompos improvements #270

Merged
merged 10 commits into from
Sep 17, 2018
Merged

VMM'18 Demo and Kompos improvements #270

merged 10 commits into from
Sep 17, 2018

Conversation

smarr
Copy link
Owner

@smarr smarr commented Sep 16, 2018

Changes for the VMM'18 demo.

This PR includes a port of @daumayr's ReplayDemo.ns airline booking system.

It fixes various other details, and adds a checkbox to enable a demo-mode layout in Kompos.

It also improves the performance of the rendering in Kompos.
This is done by avoiding sending unnecessary symbol messages, and by delaying rendering to avoid unnecessary repainting.

- no radio input
- font size can be small

Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
This example was originally implemented by Dominik Aumayr for his master thesis work.

Signed-off-by: Stefan Marr <[email protected]>
@smarr smarr added the enhancement Improves the implementation with something noteworthy label Sep 16, 2018
@smarr smarr added this to the v0.7.0 milestone Sep 16, 2018
Move getSectionIdFromFrame out of debugger, seems more general. locate it next to getSectionId in messages.ts.

Make all elements that have a source location clickable.

Signed-off-by: Stefan Marr <[email protected]>
daumayr and others added 4 commits September 16, 2018 18:45
Co-authored-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
This avoids rendering it when date is already outdated.

Signed-off-by: Stefan Marr <[email protected]>
All types of passive entities are now grouped based on their origin.

Signed-off-by: Stefan Marr <[email protected]>
@smarr smarr changed the title VMM'18 Demo VMM'18 Demo and Kompos improvements Sep 16, 2018
@smarr
Copy link
Owner Author

smarr commented Sep 16, 2018

@daumayr would be great, if you could give this a brief review.

Copy link
Contributor

@daumayr daumayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, you cleaned up my grouping hack and it looks like you took care of the frequent layout changes

@smarr smarr merged commit ab4fc0b into dev Sep 17, 2018
@smarr smarr deleted the async-demo branch September 17, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the implementation with something noteworthy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants