-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMM'18 Demo and Kompos improvements #270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no radio input - font size can be small Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
This example was originally implemented by Dominik Aumayr for his master thesis work. Signed-off-by: Stefan Marr <[email protected]>
smarr
added
the
enhancement
Improves the implementation with something noteworthy
label
Sep 16, 2018
Move getSectionIdFromFrame out of debugger, seems more general. locate it next to getSectionId in messages.ts. Make all elements that have a source location clickable. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Co-authored-by: Stefan Marr <[email protected]> Signed-off-by: Stefan Marr <[email protected]>
This avoids rendering it when date is already outdated. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
All types of passive entities are now grouped based on their origin. Signed-off-by: Stefan Marr <[email protected]>
@daumayr would be great, if you could give this a brief review. |
daumayr
reviewed
Sep 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, you cleaned up my grouping hack and it looks like you took care of the frequent layout changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for the VMM'18 demo.
This PR includes a port of @daumayr's
ReplayDemo.ns
airline booking system.It fixes various other details, and adds a checkbox to enable a demo-mode layout in Kompos.
It also improves the performance of the rendering in Kompos.
This is done by avoiding sending unnecessary symbol messages, and by delaying rendering to avoid unnecessary repainting.