Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange Relayer Chain interactions interfaces #903

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Rearrange Relayer Chain interactions interfaces #903

wants to merge 1 commit into from

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Oct 30, 2024

Requires

Supports

@ilija42 ilija42 requested a review from a team as a code owner October 30, 2024 12:24
@ilija42 ilija42 requested review from jmank88 and removed request for a team October 30, 2024 12:24
@ilija42 ilija42 force-pushed the extract-chain-reads branch from 24e8a40 to 34d7a88 Compare October 30, 2024 12:27
@ilija42 ilija42 force-pushed the extract-chain-reads branch from 34d7a88 to 8286a75 Compare October 30, 2024 12:27
jmank88
jmank88 reviewed Oct 30, 2024
View reviewed changes
pkg/types/relayer.go Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Oct 30, 2024
View reviewed changes
pkg/types/relayer.go Outdated Show resolved Hide resolved
@ilija42 ilija42 marked this pull request as draft October 30, 2024 13:01
@ilija42 ilija42 force-pushed the extract-chain-reads branch from 8286a75 to 51ba2fc Compare November 12, 2024 12:40
@ilija42 ilija42 force-pushed the extract-chain-reads branch from 51ba2fc to 6a3ac42 Compare November 12, 2024 13:06
@ilija42 ilija42 changed the title Extract chain reads from ChainService relayer into Chain Reader Rearrange Relayer Chain interactions interfaces Nov 12, 2024
@ilija42 ilija42 requested a review from pablolagreca November 12, 2024 13:27
jmank88
jmank88 reviewed Nov 12, 2024
View reviewed changes
pkg/types/chain_writer.go Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 12, 2024
View reviewed changes
pkg/types/relayer.go Outdated Show resolved Hide resolved
@ilija42 ilija42 force-pushed the extract-chain-reads branch from 6a3ac42 to 4eaa82c Compare November 12, 2024 13:32
pablolagreca
pablolagreca suggested changes Nov 26, 2024
View reviewed changes
pkg/types/relayer.go Outdated Show resolved Hide resolved
pkg/loop/internal/types/types.go Show resolved Hide resolved
@ilija42 ilija42 mentioned this pull request Nov 26, 2024
Merged
pablolagreca
pablolagreca previously approved these changes Nov 26, 2024
View reviewed changes
@ilija42 ilija42 force-pushed the extract-chain-reads branch from f0a52bb to 18cfff0 Compare December 5, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 left review comments

@pablolagreca pablolagreca pablolagreca left review comments

@patrick-dowell patrick-dowell Awaiting requested review from patrick-dowell

At least 2 approving reviews are required to merge this pull request.

Assignees

@patrick-dowell patrick-dowell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilija42 @pablolagreca @jmank88 @patrick-dowell