New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add require.eventually to reduce test flakiness #582

Merged

aalu1418 merged 1 commit into develop from fix/client-test-flakiness

Feb 12, 2024

Collaborator

aalu1418 commented Feb 9, 2024

occasional test flakiness in race testing

=== RUN   TestClient_SendTxDuplicates_Integration
    ports.go:37: found open port: 5252
    ports.go:37: found open port: 59828
    client_test.go:277: 
        	Error Trace:	/home/runner/work/chainlink-solana/chainlink-solana/pkg/solana/client/client_test.go:277
        	Error:      	Not equal: 
        	            	expected: 0x0
        	            	actual  : 0x1388
        	Test:       	TestClient_SendTxDuplicates_Integration
--- FAIL: TestClient_SendTxDuplicates_Integration (3.53s)


          add require.eventually to reduce test flakiness

71357fa

aalu1418 temporarily deployed to integration

February 9, 2024 17:24

— with

GitHub Actions Inactive

aalu1418 temporarily deployed to integration

February 9, 2024 17:24

— with

GitHub Actions Inactive

aalu1418 temporarily deployed to integration

February 9, 2024 17:24

— with

GitHub Actions Inactive

cl-sonarqube-production bot commented Feb 9, 2024

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

aalu1418 temporarily deployed to integration

February 9, 2024 17:31

— with

GitHub Actions Inactive

aalu1418 requested review from krebernisak and smickovskid

February 9, 2024 19:46

jmank88 approved these changes

View reviewed changes

aalu1418 merged commit c4e464d into develop

25 checks passed

aalu1418 deleted the fix/client-test-flakiness branch

February 12, 2024 14:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet