-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1741] performance comparison tool #1424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofel
force-pushed
the
tt-1741-performance-comparison-tool
branch
from
December 3, 2024 12:43
1d5ca0c
to
a21de6f
Compare
… more test for 2 loki queries; query executor and loki parallelization; added todo
skudasov
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM 🚀 Please continue, then let's test PoC with some real load and have a second round of review @Tofel !
skudasov
reviewed
Dec 3, 2024
…test start/end time from segments
…e not limits/constraints
Tofel
force-pushed
the
tt-1741-performance-comparison-tool
branch
from
December 5, 2024 08:40
6474015
to
dcdd2e0
Compare
skudasov
approved these changes
Dec 19, 2024
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The updates ensure accurate timestamp parsing, enhance flexibility in log entry processing, and improve file and performance testing management. These changes support diverse timestamp formats, streamline performance analysis, and enhance project organization.
What
performance_reports/
directory to exclude performance test reports from version control, keeping the repository clean.basic.go
,loki.go
,report.go
,resources.go
,storage.go
,types.go
) to implement a detailed framework for performance testing, including handling of basic data, Loki queries, report generation, resource tracking, and storage management.