Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1741] performance comparison tool #1424

Merged
merged 64 commits into from
Dec 19, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Dec 3, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The updates ensure accurate timestamp parsing, enhance flexibility in log entry processing, and improve file and performance testing management. These changes support diverse timestamp formats, streamline performance analysis, and enhance project organization.

What

  • lib/client/loki.go: Enhanced timestamp parsing to support string, integer, and float formats, improving log data compatibility.
  • wasp/.gitignore: Included performance_reports/ directory to exclude performance test reports from version control, keeping the repository clean.
  • wasp/benchspy/: Introduced new files (basic.go, loki.go, report.go, resources.go, storage.go, types.go) to implement a detailed framework for performance testing, including handling of basic data, Loki queries, report generation, resource tracking, and storage management.
  • wasp/benchspy_test.go: Added a test file for the BenchSpy tool, ensuring the functionality of the performance testing framework.
  • wasp/go.mod and wasp/go.sum: Updated module dependencies to support the newly added functionality and improvements.

@Tofel Tofel force-pushed the tt-1741-performance-comparison-tool branch from 1d5ca0c to a21de6f Compare December 3, 2024 12:43
@skudasov skudasov self-requested a review December 3, 2024 16:20
Copy link
Collaborator

@skudasov skudasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 🚀 Please continue, then let's test PoC with some real load and have a second round of review @Tofel !

lib/client/loki.go Show resolved Hide resolved
wasp/benchspy/basic.go Outdated Show resolved Hide resolved
wasp/benchspy/basic.go Show resolved Hide resolved
wasp/benchspy_test.go Outdated Show resolved Hide resolved
wasp/benchspy_test.go Outdated Show resolved Hide resolved
wasp/go.mod Outdated Show resolved Hide resolved
wasp/wasp.go Outdated Show resolved Hide resolved
wasp/benchspy/resources.go Outdated Show resolved Hide resolved
wasp/benchspy_test.go Outdated Show resolved Hide resolved
@Tofel Tofel force-pushed the tt-1741-performance-comparison-tool branch from 6474015 to dcdd2e0 Compare December 5, 2024 08:40
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
13.2% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube

@skudasov skudasov merged commit d415e31 into main Dec 19, 2024
47 of 50 checks passed
@skudasov skudasov deleted the tt-1741-performance-comparison-tool branch December 19, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants