Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NONEVM-1319] - Solana Contract Reader Dest and Source cfg #16308

Merged
merged 17 commits into from
Feb 15, 2025
Merged

[NONEVM-1319] - Solana Contract Reader Dest and Source cfg #16308

merged 17 commits into from
Feb 15, 2025

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Feb 10, 2025 •
edited
Loading

There are still details to be ironed out with onchain, mostly around onramp. Left TODOs for things I am not 100% sure on that have to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ilija42 ilija42 marked this pull request as ready for review February 11, 2025 00:10
@ilija42 ilija42 requested review from a team as code owners February 11, 2025 00:10
@ilija42 ilija42 changed the title Solana cr cfg [NONEVM-1319] - Solana Contract Reader Dest and Source cfg Feb 11, 2025
@ilija42 ilija42 force-pushed the solana-cr-cfg branch 3 times, most recently from 32e147b to b6ea632 Compare February 11, 2025 00:20
jmank88
jmank88 previously approved these changes Feb 11, 2025
View reviewed changes
@ilija42 ilija42 requested review from a team as code owners February 11, 2025 10:42
@ilija42 ilija42 requested a review from a team as a code owner February 12, 2025 00:53
amit-momin
amit-momin previously approved these changes Feb 14, 2025
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
50.6% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Feb 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2025
@archseer archseer added this pull request to the merge queue Feb 15, 2025
Merged via the queue into develop with commit 6272fc5 Feb 15, 2025
201 of 203 checks passed
@archseer archseer deleted the solana-cr-cfg branch February 15, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer left review comments

@winder winder winder approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@amit-momin amit-momin amit-momin approved these changes

@jmank88 jmank88 jmank88 left review comments

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19 patrickhuie19 is a code owner automatically assigned from smartcontractkit/foundations

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilija42 @winder @jmank88 @archseer @prashantkumar1982 @amit-momin