Update ci/ethereum_test to check echo_server/RunLog #276
Conversation
dimroc
force-pushed
the
chores/runlog-integration-test
branch
from
7073533 to
d780c74
Compare
| @@ -2,11 +2,11 @@ let LinkToken = artifacts.require("../node_modules/smartcontractkit/chainlink/so | |||
| let RunLog = artifacts.require("./RunLog.sol"); | |||
| let devnetAddress = "0x9CA9d2D5E04012C9Ed24C0e513C9bfAa4A2dD77f"; | |||
|
|
|||
| module.exports = async function(deployer) { | |||
| await LinkToken.deployed().then(async function(linkInstance) { | |||
| module.exports = function(deployer) { | |||
There was a problem hiding this comment.
Apparently truffle migrations don't support async at the top export level, but they do inside then(async....:
trufflesuite/truffle#501
There was a problem hiding this comment.
Maybe still return result of LinkToken.deployed? Not sure about Truffle's internals, but in tests it waits for returned promises to finish.
There was a problem hiding this comment.
I tried that to no avail and felt this was the most confident solution.
dimroc
force-pushed
the
chores/runlog-integration-test
branch
from
d780c74 to
59a1659
Compare
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 45 45
Lines 3635 3635
=======================================
Hits 3040 3040
Misses 378 378
Partials 217 217
Continue to review full report at Codecov.
|
dimroc
changed the title
internal/ci/ethereum_test
Outdated
| cd ../../ | ||
|
|
||
| ## Check job counts | ||
| jobs=`cldev -j j | jq length` |
There was a problem hiding this comment.
Should we document the jq requirement somewhere?
There was a problem hiding this comment.
I'm indifferent. I do think this script assumes a lot of things are installed so how do we draw the line between jq and other dependencies (yarn, curl, node)? It's preinstalled on the CI servers because it's prevalent in the ops world. Are you just saying something like?
## jq is used to parse json: https://stedolan.github.io/jq/| 7. Wait for log to show up in echo server | ||
| 2. `yarn install` | ||
| 3. `node echo.js` | ||
| 4. `./node_modules/.bin/truffle migrate` in another window |
There was a problem hiding this comment.
node echo.js locks up the current window.
dimroc
force-pushed
the
chores/runlog-integration-test
branch
2 times, most recently
from
e1f8b8b to
c0b8a35
Compare
dimroc
force-pushed
the
chores/runlog-integration-test
branch
from
c0b8a35 to
7562fc8
Compare
No description provided.