-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor]: Source Adapters newest pattern #1524
Conversation
🦋 Changeset detectedLatest commit: ecdac19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/composites/bitcoin-json-rpc/src/endpoint/getblockchaininfo.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this error in CI:
TS6059: File '/home/node/app/packages/sources/json-rpc/src/adapter.ts' is not under 'rootDir' '/home/node/app/packages/sources/reduce/src'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Root file specified for compilation
[tsl] ERROR in /home/node/app/packages/sources/json-rpc/src/adapter.ts(3,44)
TS6059: File '/home/node/app/packages/sources/json-rpc/src/config.ts' is not under 'rootDir' '/home/node/app/packages/sources/reduce/src'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Imported via './config' from file '/home/node/app/packages/sources/json-rpc/src/adapter.ts'
Imported via '../config' from file '/home/node/app/packages/sources/json-rpc/src/endpoint/request.ts'
Root file specified for compilation
[tsl] ERROR in /home/node/app/packages/sources/json-rpc/src/adapter.ts(4,28)
TS6059: File '/home/node/app/packages/sources/json-rpc/src/endpoint/index.ts' is not under 'rootDir' '/home/node/app/packages/sources/reduce/src'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Imported via './endpoint' from file '/home/node/app/packages/sources/json-rpc/src/adapter.ts'
Root file specified for compilation
[tsl] ERROR in /home/node/app/packages/sources/json-rpc/src/endpoint/index.ts(1,26)
TS6059: File '/home/node/app/packages/sources/json-rpc/src/endpoint/request.ts' is not under 'rootDir' '/home/node/app/packages/sources/reduce/src'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Imported via './request' from file '/home/node/app/packages/sources/json-rpc/src/endpoint/index.ts'
Root file specified for compilation
at /home/node/app/.yarn/cache/@vercel-ncc-npm-0.29.2-3d07d22bfe-08491dbaff.zip/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1862768
at /home/node/app/.yarn/cache/@vercel-ncc-npm-0.29.2-3d07d22bfe-08491dbaff.zip/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:336439
at _done (eval at create (/home/node/app/.yarn/cache/@vercel-ncc-npm-0.29.2-3d07d22bfe-08491dbaff.zip/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:117892), <anonymous>:9:1)
24934c5
to
4e7d524
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Part of #1471 |
Description
add the newest pattern in source adapters
Quality Assurance
yarn changeset
if adapter source code was changed<ADAPTER_PACKAGE>/schemas/env.json
and<ADAPTER_PACKAGE>/README.md
infra-k8s
configuration file.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Clubhouse/Shortcut