Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Source Adapters newest pattern #1524

Merged
merged 18 commits into from
Feb 9, 2022
Merged

Conversation

bogos
Copy link
Contributor

@bogos bogos commented Feb 3, 2022

Description

add the newest pattern in source adapters

Quality Assurance

  • Ran yarn changeset if adapter source code was changed
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant <ADAPTER_PACKAGE>/schemas/env.json and <ADAPTER_PACKAGE>/README.md
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Clubhouse/Shortcut
  • This is related to a maximum of one Clubhouse/Shortcut story or GitHub issue
  • [X ] Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types)

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2022

🦋 Changeset detected

Latest commit: ecdac19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@chainlink/fcsapi-adapter Minor
@chainlink/finnhub-adapter Minor
@chainlink/json-rpc-adapter Minor
@chainlink/kaiko-adapter Minor
@chainlink/layer2-sequencer-health-adapter Minor
@chainlink/lcx-adapter Minor
@chainlink/linkpool-adapter Minor
@chainlink/reduce-adapter Minor
@chainlink/renvm-address-set-adapter Minor
@chainlink/market-closure-adapter Patch
@chainlink/ea Patch
@chainlink/bitcoin-json-rpc-adapter Patch
@chainlink/bob-adapter Patch
@chainlink/lotus-adapter Patch
@chainlink/token-allocation-adapter Patch
@chainlink/proof-of-reserves-adapter Patch
@chainlink/outlier-detection-adapter Patch
@chainlink/reference-transform-adapter Patch
@chainlink/anchor-adapter Patch
@chainlink/apy-finance-adapter Patch
@chainlink/crypto-volatility-index-adapter Patch
@chainlink/defi-dozen-adapter Patch
@chainlink/defi-pulse-adapter Patch
@chainlink/dxdao-adapter Patch
@chainlink/linear-finance-adapter Patch
@chainlink/set-token-index-adapter Patch
@chainlink/synth-index-adapter Patch
@chainlink/vesper-adapter Patch
@chainlink/xsushi-price-adapter Patch
@chainlink/por-indexer-adapter Patch
@chainlink/wbtc-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bogos bogos requested a review from austinborn February 3, 2022 05:11
@bogos bogos temporarily deployed to QA February 3, 2022 05:40 Inactive
@bogos bogos temporarily deployed to QA February 3, 2022 15:32 Inactive
@justinkaseman justinkaseman temporarily deployed to QA February 4, 2022 16:42 Inactive
@justinkaseman justinkaseman self-requested a review February 4, 2022 17:00
Copy link
Collaborator

@justinkaseman justinkaseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this error in CI:

TS6059: File '/home/node/app/packages/sources/json-rpc/src/adapter.ts' is not under 'rootDir' '/home/node/app/packages/sources/reduce/src'. 'rootDir' is expected to contain all source files. 

 The file is in the program because: 

 Root file specified for compilation 

[tsl] ERROR in /home/node/app/packages/sources/json-rpc/src/adapter.ts(3,44) 

 TS6059: File '/home/node/app/packages/sources/json-rpc/src/config.ts' is not under 'rootDir' '/home/node/app/packages/sources/reduce/src'. 'rootDir' is expected to contain all source files. 

 The file is in the program because: 

 Imported via './config' from file '/home/node/app/packages/sources/json-rpc/src/adapter.ts' 

 Imported via '../config' from file '/home/node/app/packages/sources/json-rpc/src/endpoint/request.ts' 

 Root file specified for compilation 

[tsl] ERROR in /home/node/app/packages/sources/json-rpc/src/adapter.ts(4,28) 

 TS6059: File '/home/node/app/packages/sources/json-rpc/src/endpoint/index.ts' is not under 'rootDir' '/home/node/app/packages/sources/reduce/src'. 'rootDir' is expected to contain all source files. 

 The file is in the program because: 

 Imported via './endpoint' from file '/home/node/app/packages/sources/json-rpc/src/adapter.ts' 

 Root file specified for compilation 

[tsl] ERROR in /home/node/app/packages/sources/json-rpc/src/endpoint/index.ts(1,26) 

 TS6059: File '/home/node/app/packages/sources/json-rpc/src/endpoint/request.ts' is not under 'rootDir' '/home/node/app/packages/sources/reduce/src'. 'rootDir' is expected to contain all source files. 

 The file is in the program because: 

 Imported via './request' from file '/home/node/app/packages/sources/json-rpc/src/endpoint/index.ts' 

 Root file specified for compilation 

 at /home/node/app/.yarn/cache/@vercel-ncc-npm-0.29.2-3d07d22bfe-08491dbaff.zip/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1862768 

 at /home/node/app/.yarn/cache/@vercel-ncc-npm-0.29.2-3d07d22bfe-08491dbaff.zip/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:336439 


 at _done (eval at create (/home/node/app/.yarn/cache/@vercel-ncc-npm-0.29.2-3d07d22bfe-08491dbaff.zip/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:117892), <anonymous>:9:1)

@justinkaseman justinkaseman temporarily deployed to QA February 4, 2022 20:22 Inactive
@bogos bogos force-pushed the refactor/sources-ea branch from 24934c5 to 4e7d524 Compare February 8, 2022 04:58
@bogos bogos temporarily deployed to QA February 8, 2022 04:58 Inactive
@bogos bogos temporarily deployed to QA February 8, 2022 05:10 Inactive
@bogos bogos temporarily deployed to QA February 8, 2022 18:43 Inactive
Copy link
Contributor

@austinborn austinborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cl-ea cl-ea temporarily deployed to QA February 9, 2022 00:58 Inactive
@cl-ea cl-ea temporarily deployed to QA February 9, 2022 06:01 Inactive
@austinborn austinborn temporarily deployed to QA February 9, 2022 16:50 Inactive
@austinborn austinborn merged commit 048a65b into develop Feb 9, 2022
@austinborn austinborn deleted the refactor/sources-ea branch February 9, 2022 17:31
@austinborn austinborn temporarily deployed to QA February 9, 2022 17:32 Inactive
@austinborn
Copy link
Contributor

Part of #1471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants