Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #17

Merged
merged 11 commits into from
Nov 3, 2022
Merged

Add types #17

merged 11 commits into from
Nov 3, 2022

Conversation

vanshg
Copy link
Contributor

@vanshg vanshg commented Nov 2, 2022

No description provided.

mldangelo
mldangelo reviewed Nov 2, 2022
View reviewed changes
smile_id_core/__init__.py Outdated Show resolved Hide resolved
mldangelo
mldangelo reviewed Nov 2, 2022
View reviewed changes
smile_id_core/WebApi.py Show resolved Hide resolved
smile_id_core/IdApi.py Show resolved Hide resolved
smile_id_core/IdApi.py Outdated Show resolved Hide resolved
@vanshg vanshg marked this pull request as ready for review November 2, 2022 22:11
mldangelo
mldangelo approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, please update the changelog before you merge this (adding a note to the unreleased section is fine).

@vanshg vanshg merged commit 2af3c7e into main Nov 3, 2022
@vanshg vanshg deleted the add_types branch November 3, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mldangelo mldangelo mldangelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanshg @mldangelo