fix: paginators not respecting start key #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
lauzadis
reviewed
Jun 14, 2024
| @@ -148,7 +148,7 @@ class PaginatorGenerator : KotlinIntegration { | |||
| write("") | |||
| withBlock("while (hasNextPage) {", "}") { | |||
| withBlock("val req = initialRequest.copy {", "}") { | |||
| write("this.$markerLiteral = cursor") | |||
| write("this.$markerLiteral = this.$markerLiteral ?: cursor") | |||
There was a problem hiding this comment.
question / correctness: Won't this logic always use the initialRequest.$markerLiteral if it's not null? How does the cursor get updated to fetch the second page in that case?
I was expecting the fix to be changing L146 to:
write("var cursor: #F = initialRequest.#L", cursorSymbol, markerLiteral)This will be null when the initialRequest.$markerLiteral is not set, preserving existing behavior
lauzadis
reviewed
Jun 14, 2024
| { | ||
| "id": "15fb7dc6-dee9-4f40-adba-a48183d4f432", | ||
| "type": "bugfix", | ||
| "description": "Paginators not respecting start key", |
There was a problem hiding this comment.
nit: usually the changelog description should finish the sentence "This PR will..."
"Fix paginators not respecting start key"
Affected ArtifactsNo artifacts changed size |
lauzadis
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
aws-sdk-kotlin#1330
Description of changes
Check if start key is exists before setting it to null
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.