fix(rt): constrain RFC-3339 timestamps to microsecond precision #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneekey23
reviewed
Aug 30, 2021
| @@ -40,7 +41,7 @@ actual class Instant(internal val value: jtInstant) : Comparable<Instant> { | |||
| * Encode the [Instant] as a string into the format specified by [TimestampFormat] | |||
| */ | |||
| actual fun format(fmt: TimestampFormat): String = when (fmt) { | |||
| TimestampFormat.ISO_8601 -> ISO_INSTANT.format(value) | |||
| TimestampFormat.ISO_8601 -> ISO_INSTANT.format(value.truncatedTo(ChronoUnit.MICROS)) | |||
There was a problem hiding this comment.
is there any downside to always defaulting to microseconds? assuming not but just asking
There was a problem hiding this comment.
The downside is loss of resolution but there is going to be no way to tell which services support finer grained precision.
There was a problem hiding this comment.
I figured there was no way to tell
ianbotsf
approved these changes
Aug 30, 2021
aajtodd
added a commit
that referenced
this pull request
Mar 11, 2024
…ible (#469) Refactor credential providers to remove CRT dependency and make them KMP compatible. Added SSO provider to default chain. Lots of misc cleanup and improvements. * feat(rt): standalone sso credentials provider (#462) * refactor(rt)!: generated sts and sts web identity credential providers (#470) * refactor(rt)!: implement kmp ecs provider (#475) * feat(rt)!: implement kmp profile credentials provider (#478) * feat(rt)!: kmp default credentials provider chain (#491) * fix: work around machine-specific Gradle bug with aws-config variants (#496) * fix: credentials provider ownership (#498) Co-authored-by: Ian Botsford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
fixes awslabs/aws-sdk-kotlin#304
Description of changes
Restrict RFC-3339 (ISO-8601) timestamps to microsecond precision
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.