Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kotlin and Dokka versions to latest release #506

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

kggilmer
Copy link
Contributor

@kggilmer kggilmer commented Oct 20, 2021

Issue #

Companion PRs:

Description of changes

  • Update Kotlin and Dokka to 1.5.31 to support documentation generation

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: While the gradle.properties changes seem fine, I see the version number listed in other places:

Do these locations need to be updated as well?

@aajtodd
Copy link
Contributor

aajtodd commented Oct 21, 2021

Question: While the gradle.properties changes seem fine, I see the version number listed in other places:

* [**runtime/runtime-core/build.gradle.kts**](https://github.com/awslabs/smithy-kotlin/blob/main/runtime/runtime-core/build.gradle.kts#L7)

* [**runtime/serde/serde-json/TESTING.md**](https://github.com/awslabs/smithy-kotlin/blob/main/runtime/serde/serde-json/TESTING.md)

* [**KotlinDependency.kt**](https://github.com/awslabs/smithy-kotlin/blob/main/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/KotlinDependency.kt#L37)

Do these locations need to be updated as well?

So for the runtime build.gradle.kts, same comment. Hopefully this shouldn't be necessary anymore because we default the versions here.

The KotlinDependency.kt shouldn't matter in practice but it's fine to update.

The TESTING.md can be ignored. It's just instructions for how to get started setting up JSONTestSuite. (I don't want to be updating versions more than we need to)

@kggilmer
Copy link
Contributor Author

For consistency I updated everything except for the json testing, as I think it's better to keep that version sticky unless we want to verify that the tests continue to work from upgrade to upgrade.

The TESTING.md can be ignored. It's just instructions for how to get started setting up JSONTestSuite. (I don't want to be updating versions more than we need to)

agreed

@kggilmer kggilmer merged commit a313095 into main Oct 21, 2021
@kggilmer kggilmer deleted the chore-update-kotlin-dokka-version branch October 21, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants